Skip to content

Remove eps_attr config field#1379

Merged
jlarson4 merged 1 commit into
TransformerLensOrg:devfrom
RecreationalMath:remove-eps-attr
Jun 11, 2026
Merged

Remove eps_attr config field#1379
jlarson4 merged 1 commit into
TransformerLensOrg:devfrom
RecreationalMath:remove-eps-attr

Conversation

@RecreationalMath

Copy link
Copy Markdown
Contributor

Description

Closes #1376.

Removes the unused eps_attr field from TransformerBridgeConfig. It was set by 8 architecture adapters but read nowhere (its only consumer was deleted in #1119 when NormalizationBridge moved to direct HF delegation), so removing it changes no model behavior.

It is a breaking API change: the eps_attr constructor argument and the config.eps_attr attribute are gone (the field was live, never deprecated). Serialized configs are unaffected (from_dict drops unknown keys). The break only hits code that passes eps_attr= to the constructor or reads config.eps_attr.

Removed in one sweep: the config field, the 8 adapter self.cfg.eps_attr = ... assignments, the 6 adapter-test assertions, and the doc/template mentions (including the now-dead cfg.eps_attr troubleshooting row in the numerical-divergence guide).

Note: deleted the troubleshooting row rather than rewire it, since the eps machinery already auto-introspects .eps/.variance_epsilon (a transformers 5.8.1 scan found no HF norm using another attribute name), so the symptom is not user-actionable via this field.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

Breaking: removes the public eps_attr constructor argument and the config.eps_attr attribute. The field was never read (its consumer was deleted when NormalizationBridge moved to direct HF delegation), so no model behavior changes, but it is an API removal.
@RecreationalMath RecreationalMath changed the title Remove unused eps_attr config field Remove eps_attr config field Jun 11, 2026
@jlarson4 jlarson4 merged commit d4e1800 into TransformerLensOrg:dev Jun 11, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants